Rename thermo-nuclear-code-quality-review to code-quality-review and drop the dramatic wording; allow security-audit model invocation. Both now run as extra axes in the implementation-orchestrator and orchestrate-herdr review steps.
6.2 KiB
name, description, disable-model-invocation
| name | description | disable-model-invocation |
|---|---|---|
| implementation-orchestrator | Implements ready-for-agent tracker tickets through isolated worktrees, pull requests, review, conflict resolution, and merge. Use after wayfinder and planning have produced tickets, with or without a ticket ID/URL; no ticket ID/URL means process available tickets. Does not create planning tickets. | true |
Implementation orchestrator
Use this skill only after the human-led wayfinder, plan, spec, and ticket phases. A tracker ticket ID or URL is optional. Without one, process all eligible open tickets in the current repository. With an argument, process only that ticket. An ID means the forge's issue/ticket identifier, not a branch, session, or PR ID.
Compose before acting
Read and use these skills for their specialized work:
pi-subagentsfor parallel workers and managed worktreesworktreesfor worktree conventions and cleanupcode-reviewfor independent correctness/spec and standards reviewresolving-merge-conflictsfor conflicts; never abort a merge or rebaseforge-clifor forge selection, authentication, and CLI recipes
Load the shared forge-cli skill and run its bundled read-only preflight with the target repository as the working directory. Read only the detected CLI recipe; copy those commands instead of rediscovering syntax. Run <cli> <command> --help only when a recipe fails with an unknown command or flag. Do not add an API client or dependency.
Durable state
The tracker is the source of truth. Read the root, every candidate ticket, and their existing comments before acting. Use one active label per ticket:
workflow:ready-for-agentworkflow:ready-for-humanworkflow:implementingworkflow:pr-openworkflow:reviewworkflow:changes-requestedworkflow:conflictworkflow:blockedworkflow:merged
Comments are the message board. Record claims, status, evidence, questions, decisions, handoffs, PR URLs, check results, and recovery details there. If a worker has an issue with a ticket, comment on the ticket and wait for the human or another agent rather than guessing. For PR/MR issues, use the PR/MR's native comment/review function and also link the discussion from the ticket. Use DEV_WORKFLOW_HUMAN_REVIEWER or repository workflow configuration for the human identity; if none is configured, ask before assigning and do not invent an identity.
Run loop
- Scope. If a ticket ID/URL is supplied, confirm it belongs to the current repository and inspect only that ticket; do not process its siblings, parent, or descendants. If omitted, query all open tickets in the current repository. Use native child/dependency relationships; otherwise require explicit linked URLs or the documented blocker marker. Never infer order from titles.
- Schedule. Eligible means open, unassigned, unblocked, and labelled
workflow:ready-for-agent. Alreadyworkflow:ready-for-humantickets are skipped and reported. For a supplied ticket, process only that ticket; if it is blocked, report it and do not process its blockers. With no supplied ticket, build the dependency frontier: launch currently unblocked tickets in parallel, up to three workers, and hold dependent tickets until every blocker is merged or otherwise resolved. Re-query after each merge and launch newly unblocked tickets; dependency chains therefore run sequentially while unrelated tickets remain parallel. - Claim. Assign each selected ticket to the current forge identity before work. Replace its state with
workflow:implementingand comment the claim. - Implement. Launch one worker per ticket with
pi-subagentsin an isolated worktree, maximum three in flight by default. Pass the complete ticket, comments, acceptance criteria, non-goals, linked context, and validation contract. Each worker makes only ticket-scoped changes, commits them, and reports changed files and checks. - Escalate. For missing requirements, unsafe ambiguity, credentials, unrelated scope, or a product/architecture decision, stop. For human review or judgment, assign the ticket to the configured human reviewer, apply
workflow:ready-for-human, and comment the exact request. If no human identity is configured, ask before assigning and changing the state. Useworkflow:blockedfor non-human blockers. Preserve the worktree on failure. - PR. Run documented local checks. Push the branch and create exactly one PR/MR for the ticket. Link the ticket's tracker ID and title in the PR/MR, set
workflow:pr-open, and comment the PR/MR URL on the ticket. Keep the worktree. - Review. Set
workflow:review. Run a fresh-contextcode-reviewreview with correctness/spec and standards axes separate. Then run thesecurity-auditandcode-quality-reviewboth in their ownreviewersubagent. Post findings through the PR/MR comment/review function. For actionable findings, setworkflow:changes-requested, send one fix worker, rerun checks, and repeat. Allow at most three rounds. - Conflict. Set
workflow:conflict, then followresolving-merge-conflicts. Inspect both intents, preserve them where possible, never invent behavior, never abort, rerun local checks, and update the PR/MR. If judgment is needed, assign the PR/MR and ticket to the configured human reviewer, applyworkflow:ready-for-human, and comment the request in both places. If no human identity is configured, ask before assigning. - Merge. Merge only after independent review is clean, local checks pass, forge CI is green, the target is still the expected default branch, and no human decision or blocker remains. Comment the merge receipt and outcome, close the ticket, apply
workflow:mergedwhen supported, verify integration, then remove the worktree. - Finish. Report merged tickets and PR/MR URLs, human handoffs, blocked tickets, failed checks, review rounds, and remaining eligible tickets. Report
doneonly when no open implementation or human tickets remain in the selected scope. If only human tickets remain, reportwaiting-on-human.
Never parallel-write a shared checkout. Never silently relabel an existing human ticket. Never merge around a failed check, unresolved review finding, conflict, or missing decision.