From 8af5a20da5d66d90184d0cbf98f9b2c2db409051 Mon Sep 17 00:00:00 2001 From: Steve Beaulac Date: Fri, 26 Jun 2026 14:00:55 -0400 Subject: [PATCH] docs(triage): add `needs-review` and `in-progress` labels - Replace `in-review` with `needs-review` in implement-issue workflow - Document `needs-review` and `in-progress` labels in triage labels table - Sync label definitions across setup-skills and docs/agents --- common/engineering/implement-issue/SKILL.md | 2 +- common/engineering/setup-skills/triage-labels.md | 2 ++ docs/agents/triage-labels.md | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/common/engineering/implement-issue/SKILL.md b/common/engineering/implement-issue/SKILL.md index 2bef924..03f7326 100644 --- a/common/engineering/implement-issue/SKILL.md +++ b/common/engineering/implement-issue/SKILL.md @@ -159,7 +159,7 @@ Assemble a single prompt that the child agent will receive. Include: 6. Push the branch: `git push origin ` 7. Create a PR with: link to the issue, one-sentence summary, short key-changes list 8. Comment on the issue with the PR link: `tea comment "PR opened: "` - 9. Change the issue label to `in-review`: `tea issues edit --add-labels "in-review" --remove-labels "in-progress"` + 9. Change the issue label to `needs-review`: `tea issues edit --add-labels "needs-review" --remove-labels "in-progress"` 10. Print `DONE — issue #` - **Failure instruction**: "If any step fails, report where you stopped and what remains for manual recovery. Print the exact commands needed." diff --git a/common/engineering/setup-skills/triage-labels.md b/common/engineering/setup-skills/triage-labels.md index 835d85e..4e4a1f5 100644 --- a/common/engineering/setup-skills/triage-labels.md +++ b/common/engineering/setup-skills/triage-labels.md @@ -6,8 +6,10 @@ The skills speak in terms of five canonical triage roles. This file maps those r | -------------------------- | -------------------- | ---------------------------------------- | | `needs-triage` | `needs-triage` | Maintainer needs to evaluate this issue | | `needs-info` | `needs-info` | Waiting on reporter for more information | +| `needs-review` | `needs-review` | Waiting for reviewed by a human | | `ready-for-agent` | `ready-for-agent` | Fully specified, ready for an AFK agent | | `ready-for-human` | `ready-for-human` | Requires human implementation | +| `in-progress` | `in-progress` | Being actively worked on by a human or agents | | `wontfix` | `wontfix` | Will not be actioned | When a skill mentions a role (e.g. "apply the AFK-ready triage label"), use the corresponding label string from this table. diff --git a/docs/agents/triage-labels.md b/docs/agents/triage-labels.md index 520954c..9b56521 100644 --- a/docs/agents/triage-labels.md +++ b/docs/agents/triage-labels.md @@ -6,8 +6,10 @@ The skills speak in terms of five canonical triage roles. This file maps those r | -------------------------- | -------------------- | ---------------------------------------- | | `needs-triage` | `needs-triage` | Maintainer needs to evaluate this issue | | `needs-info` | `needs-info` | Waiting on reporter for more information | +| `needs-review` | `needs-review` | Waiting for reviewed by a human | | `ready-for-agent` | `ready-for-agent` | Fully specified, ready for an AFK agent | | `ready-for-human` | `ready-for-human` | Requires human implementation | +| `in-progress` | `in-progress` | Being actively worked on by a human or agents | | `wontfix` | `wontfix` | Will not be actioned | When a skill mentions a role (e.g. "apply the AFK-ready triage label"), use the corresponding label string from this table.